Keen-UI icon indicating copy to clipboard operation
Keen-UI copied to clipboard

Published 20 hours ago • verified publisher icon JosephusPaye

Added the icon prop to the UiTab component

Open kilobyte2007 opened this issue 2 years ago • 7 comments

The reason for this is that in Vue 3 we are required to use

kilobyte2007 avatar Aug 28 '22 15:08 kilobyte2007

Hey, fixed the issues and commented on one of them which was intended.

kilobyte2007 avatar Aug 30 '22 13:08 kilobyte2007

Hey @JosephusPaye any update here?

kilobyte2007 avatar Sep 16 '22 14:09 kilobyte2007

Hi @kilobyte2007 I'll have a look at this an the other PRs soon. Just very busy right now.

JosephusPaye avatar Sep 17 '22 05:09 JosephusPaye

Looks good 👍. Could you please add an example that uses the #icon slot? That way we have something that tests it.

JosephusPaye avatar Sep 27 '22 10:09 JosephusPaye

Actually, 2 of the examples are already using the icon slot (as it was done previously) so we already have something that tests it.

kilobyte2007 avatar Sep 27 '22 15:09 kilobyte2007

Sorry for the confusion if I'm missing something, but I can you point me to which examples use the icon slot? From what I can see they all use the icon prop on UiTab except for the custom header one which uses the header slot to render a UiIcon and the tab title.

JosephusPaye avatar Oct 11 '22 08:10 JosephusPaye

I was referring to the first example: image

kilobyte2007 avatar Oct 11 '22 08:10 kilobyte2007

Looks like something weird is happening. I can see on your branch the example with the icon template, but on this PR for some reason it's not the same.

This is what I see when I clone this PR

image

Anyway this PR looks good. I'll go ahead and merge it now. Thanks for your patience!

JosephusPaye avatar Dec 15 '22 08:12 JosephusPaye