Keen-UI icon indicating copy to clipboard operation
Keen-UI copied to clipboard

Dart Sass deprecation warnings

Open desko27 opened this issue 2 years ago • 1 comments

We just migrated from node-sass (which is deprecated) to the recommended sass package and encountered we cannot fix these warnings in our Vue project as they originate from keen-ui components.

This is just an example but there are lots of them:

DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div(strip-unit($value), strip-unit($base))

More info and automated migrator: https://sass-lang.com/d/slash-div

   ╷
57 │         $value: strip-unit($value) / strip-unit($base) * 1rem;
   │                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   ╵
    node_modules/keen-ui/src/styles/util.scss 57:17       to-rem()
    node_modules/keen-ui/src/styles/util.scss 31:17       rem()
    node_modules/keen-ui/src/styles/variables.scss 33:39  @import
    node_modules/keen-ui/src/styles/imports.scss 2:9      @import
    stdin 155:9                                           root stylesheet

desko27 avatar Sep 13 '21 21:09 desko27

Interesting. I'd be happy to merge a PR that fixes the warnings.

JosephusPaye avatar Sep 15 '21 04:09 JosephusPaye