Keen-UI icon indicating copy to clipboard operation
Keen-UI copied to clipboard

Published 20 hours ago • verified publisher icon JosephusPaye

UiAlert properties

Open EmilMoe opened this issue 4 years ago • 1 comments

I have 2 suggestions to this component:

  1. To make it more consistent with the rest of your UI it should have the "icon" property.

  2. I think Vue works best if boolean properties are false by default, thus prettier and easier to set. The dismissible should therefor be something that it's false. It could be either not-dismissible by default or the prop could be changed to (ie) irremovable or persist.

EmilMoe avatar Sep 28 '19 11:09 EmilMoe

Hi Emil,

Those suggestions make sense, but they'll probably be breaking changes. Can make the changes in the next major release.

PR welcome.

JosephusPaye avatar Sep 28 '19 11:09 JosephusPaye