PSZoom icon indicating copy to clipboard operation
PSZoom copied to clipboard

Published 20 hours ago • verified publisher icon JosephMcEvoy

Store API Key/Secret in module scope variable

Open b-dasass opened this issue 3 years ago • 2 comments

Storing the API Key/Secret in module scope variable instead of the global scope would protect them a little bit more. Right now everything running in PowerShell could see these variables.

Tagging my personal account @sassdawe to have a look at weekend and if time allows send a PR

b-dasass avatar Sep 24 '21 09:09 b-dasass

Hi, if I can lead you in the right direction: you should only have to modify PSZoom/Private/Get-ZoomApiCredentials.ps1 to make this work.

JosephMcEvoy avatar Sep 28 '21 21:09 JosephMcEvoy

Thank you! I haven't spent enough time looking at it just yet, but think we'll need a Set function as well. Plus switch all the $Global: variables to module scoped. I also want to create some Pester tests for the changes I'm going to introduce. If you don't mind.

sassdawe avatar Sep 29 '21 06:09 sassdawe