Joe Edwards

Results 48 comments of Joe Edwards

This is the valgrind output with those changes: [mem_leak_2.txt](https://github.com/digraphs/Digraphs/files/14873349/mem_leak_2.txt)

Unfortunately, it seems like there are still memory leaks when testing `standard/grahom.tst`: [mem_leak_3.txt](https://github.com/digraphs/Digraphs/files/15010175/mem_leak_3.txt)

@DanielPointon no need to apologise! I took the liberty of Valgrinding `tst/teststandard.g` and that seems to be leak free too. Nice job!

@james-d-mitchell will the new Valgrind action suffice? If no, I'll happily run it again. I also think I have a local copy of the old branch. If that'd be helpful...

Pushed to https://github.com/Joseph-Edwards/Digraphs And hopefully you should be able to see the Valgrind action in the actions tab. It should be callable somehow, but I'm not sure how off the...

Other than some TODOs that are either superfluous, or very easy to fix, this looks good to me. I'd be happy to merge when the tests pass

Presently, there are a few things that I'm not sure about when writing the doc. Specifically: - Which functions need \complexity - Should descriptions be "This function calculates ..." or...

Thanks for the review @james-d-mitchell. Will finish up the docs, do the Python bindings then un-draft-ify the PR.

This feature was seemingly added a while ago (see [here](https://github.com/libsemigroups/libsemigroups/blob/3e9ab19b4a81d82ee6a16ee3f87d4f00cb5c0893/include/libsemigroups/presentation.hpp#L1491C1-L1508C74)), and will be documented when #551 gets merged. Happy to close this issue @james-d-mitchell?

The API has now been streamlined so there is only one class for converting words to strings (both single words, and ranges of words), and similarly for strings to words....