GoB icon indicating copy to clipboard operation
GoB copied to clipboard

Plans to add to Extension Platform?

Open Dangry98 opened this issue 1 year ago • 1 comments

Hi, any plans to add GoB to the Blender Extension platform? Would make it easier to update.

https://extensions.blender.org/approval-queue/gob/

Review

Welcome to the platform. Some notes before we approve:

  1. Zip file contains build folder which I'm assuming is only for development environment? In that case it should be removed. Same goes for 'Blender' folder if I'm not mistaken. Only files needed for running add-on should be in zip.

  2. You use Zbrush icon in UI, are you sure that's ok? It's probably gonna be your responsibility if some copyright issues arise. We trust users have permissions for image files they use.

  3. non_portable_backslash: Use of back-slash (often used for non-portable MS-Windows paths). Common false positives include: REGEX literals. Some escape sequences. output\gob\source\geometry.py:204:17: print("\\_____") output\gob\source\preferences.py:58:67: PATH_GOZ = os.path.join(os.environ['PUBLIC'] , "Pixologic\\") Automatic review raises this flag because of Pixologic. Are those slashes at the end needed? They can cause some problems. Probably better to avoid them and use os functions instead.

  4. Btw is Pixologic still correct path? You know, after what happened.

  5. Why not Linux support? I see this doesn't use any os-specific wheels. I would assume it can work on anywhere you point DIRPATH property to?

  6. I'm not sure about screenshot you have from Zbrush. It might violate some rule here, I'm not sure, but I'm interested does it install something in Zbrush too? I think it does since I see Zbrush script in here. I will ask about that but my hunch is that it will be against some copyright issues to modify other software. Can you elaborate exactly what Zbrush script does?

Dangry98 avatar Sep 01 '24 11:09 Dangry98

  1. I removed the build folder and some other files that are not required. The Blender folder contains a GoZ configuration file which is copied to the zbrush public folder when first sensing a object fro blender to zbrush.
  2. I made new icons to replace all the zbrush icons as i could not find a clear statement on the use of those icons.
  3. Thanks for pointing this out, i removed the slashes as they are not needed.
  4. Yes pixologic is still the path used in the public folder, maybe due to update/support reasons maxon decided to keep it that way.
  5. There is no Zbrush for Linux so its questionable to support it but since there is a option to specify the path it might be possible to get it to run with a emulated zbrush. I have removed this restriction from the manifest.
  6. To be sure i will avoid all zbrush screenshots. The script is not installed but run via command line. It is a importer which just imports all the objects that have been exported form blender. The GoB_Import.txt is that script in a human readable version incase you want to see for your self what its doing.

kromar avatar Oct 07 '24 11:10 kromar