Joris Goosen

Results 107 comments of Joris Goosen

Well, turns out that is not necesarily the problem, as the Patch.cmake would still be run. But another problem is that `RScript` is used, which I think adds back this...

Im getting closer but running into trouble like: ``` [1] "Installed jaspGraphs to '/Users/joris/Broncode/JASP/build-jasp-desktop-Qt_6_5_3_for_macOS-Debug/Modules/jaspTTests/.renv/1/jaspGraphs', now running post install fixes." dyld[54036]: Library not loaded: libRInside.dylib Referenced from: /Users/joris/Broncode/JASP/build-jasp-desktop-Qt_6_5_3_for_macOS-Debug/Desktop/JASPEngine Reason: tried: 'libRInside.dylib'...

Well, I found some more problems, Rinside now actually gets patched and linked into jaspEngine. However, the module folders are still empty for some reason and also Rcpp cant be...

Hmm, Ive taken your branch as it is in [1d52f92a5d5ff362cb0bc5f5fb589cfa5cdd0f1d](https://github.com/jasp-stats/jasp-desktop/pull/5269/commits/1d52f92a5d5ff362cb0bc5f5fb589cfa5cdd0f1d) , squashed it and added some mac fixes on top to make it compile and pushed that here: https://github.com/JorisGoosen/jasp-desktop/tree/newModuleInstall however...

I guess we should move the stuff under `build/R` to `build/Modules` at least on macOs because otherwise we have to figure out exactly how to fit this into the bundle/framework...

@vandenman want to integrate my changes? Or I can push to your branch perhaps

Ok, so the problem is that Rcpp is now not in the main R library of the framework. So in jaspRcpp: ``` rinside = new RInside(); ``` Fails because it...

Ok so the code at https://github.com/jasp-stats/jasp-desktop/tree/lockfiletesting does compile for macos and locally it works. But the x86 dmg nightly gives this on startup:

Alright, this looks very cool: And it is real nice to see the result real-time while editing. However, it isn't very clear that clicking the formula adds it into the...

> I kept the default behavior the same as the original quill.js formula editor, which "cancel" input when it loses focus(fewer buttons are more concise). I like the lack of...