LibriMix icon indicating copy to clipboard operation
LibriMix copied to clipboard

Bug when only ["mix_clean"] is assigned as the target

Open leo19941227 opened this issue 3 years ago • 2 comments

It seems to me even when I only need "mix_clean", the data preparation code is still highly entangled with noise

https://github.com/JorisCos/LibriMix/blob/60199d7dfcf3fc868e6647ae3c0451a257a7bb0e/scripts/create_librimix_from_metadata.py#L158-L169

Hence, it might make more sense to always create the "noise" directory here

https://github.com/JorisCos/LibriMix/blob/60199d7dfcf3fc868e6647ae3c0451a257a7bb0e/scripts/create_librimix_from_metadata.py#L104-L109

In my use case, I find that when I only use "mix_clean" in the generate_librimix.sh script, the script will crash since the "noise" directory is not created. Please correct me if I am wrong :) Thanks!

Sincerely, Leo

leo19941227 avatar Sep 21 '21 00:09 leo19941227

I also meet this problem. Noise will always be added into the mixtures no matter what the type option is.

closedappl avatar Oct 26 '22 02:10 closedappl

Sorry for the late reply. @leo19941227 Is right there is a bug when using only mix_clean for now the only workaround is to generate the whole dataset

JorisCos avatar Oct 27 '22 12:10 JorisCos