FABProgressCircle icon indicating copy to clipboard operation
FABProgressCircle copied to clipboard

after upgrade to 1.01 the FABCircle looks like this

Open ares89 opened this issue 10 years ago • 14 comments

ermmmm, i cannot upload image image here. so this is the image: http://7qn7lj.com1.z0.glb.clouddn.com/20150617091144.png

while my xml is like this:

    <com.github.jorgecastilloprz.FABProgressCircle
        android:id="@+id/fab_set_circle"
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:layout_alignParentRight="true"
        android:layout_margin="8dp"
        app:arcColor="@color/fab_progress"
        app:arcWidth="3dp"
        app:reusable="true"
        app:roundedStroke="true">

        <android.support.design.widget.FloatingActionButton
            android:id="@+id/fab_set"
            android:layout_width="wrap_content"
            android:layout_height="wrap_content"
            android:clickable="true"
            android:src="@drawable/ic_wallpaper_white_24dp"
            app:backgroundTint="@color/fab_back"
            app:elevation="6dp"
            app:pressedTranslationZ="12dp"
            app:rippleColor="#ffffff" />
    </com.github.jorgecastilloprz.FABProgressCircle>

ares89 avatar Jun 17 '15 01:06 ares89

I am not at home atm, but i will check it out asap. In the meantime, if you find the problem pls tell me.

JorgeCastilloPrz avatar Jun 17 '15 05:06 JorgeCastilloPrz

Hi, I confirm also this issue. Still use 1.0. Thanks for the hard work.

StephaneBg avatar Jun 17 '15 11:06 StephaneBg

Paste your XML layot too if you can. I will study the problem asap. El 17/6/2015 13:03, "Stéphane B." [email protected] escribió:

Hi, I confirm also this issue. Still use 1.0. Thanks for the hard work.

— Reply to this email directly or view it on GitHub https://github.com/JorgeCastilloPrz/FABProgressCircle/issues/7#issuecomment-112755028 .

JorgeCastilloPrz avatar Jun 17 '15 11:06 JorgeCastilloPrz

<?xml version="1.0" encoding="utf-8"?>
<android.support.design.widget.CoordinatorLayout xmlns:android="http://schemas.android.com/apk/res/android"
                                                 xmlns:app="http://schemas.android.com/apk/res-auto"
                                                 xmlns:tools="http://schemas.android.com/tools"
                                                 android:layout_width="match_parent"
                                                 android:layout_height="match_parent">

    <android.support.design.widget.AppBarLayout
        android:id="@+id/appbar"
        android:layout_width="match_parent"
        android:layout_height="wrap_content"
        android:theme="@style/ThemeOverlay.AppCompat.Dark.ActionBar">

        <android.support.v7.widget.Toolbar
            android:id="@+id/toolbar"
            android:layout_width="match_parent"
            android:layout_height="?attr/actionBarSize"
            app:layout_scrollFlags="scroll|enterAlways"
            app:popupTheme="@style/ThemeOverlay.AppCompat.Light"
            app:theme="@style/ThemeOverlay.AppCompat.Dark.ActionBar"
            app:title="@string/app_name"/>

        <android.support.design.widget.TabLayout
            android:id="@+id/tabs"
            android:layout_width="match_parent"
            android:layout_height="wrap_content"
            android:visibility="gone"
            app:tabIndicatorColor="@color/white"
            tools:visibility="visible"/>
    </android.support.design.widget.AppBarLayout>

    <FrameLayout
        android:layout_width="match_parent"
        android:layout_height="match_parent"
        app:layout_behavior="@string/appbar_scrolling_view_behavior">

        <ImageView
            android:id="@+id/iv_empty"
            android:layout_width="wrap_content"
            android:layout_height="wrap_content"
            android:layout_gravity="center"
            android:src="@drawable/ic_bluetooth_disabled"/>

        <android.support.v4.view.ViewPager
            android:id="@+id/viewpager"
            android:layout_width="match_parent"
            android:layout_height="match_parent"/>

        <include layout="@layout/include_msg_bars"/>
    </FrameLayout>

    <com.github.jorgecastilloprz.FABProgressCircle
        android:id="@+id/fab_progress"
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:layout_gravity="bottom|right"
        android:layout_margin="@dimen/activity_horizontal_margin"
        android:scaleX="0"
        android:scaleY="0"
        app:arcColor="?attr/colorPrimary">

        <android.support.design.widget.FloatingActionButton
            android:id="@+id/fab"
            android:layout_width="wrap_content"
            android:layout_height="wrap_content"
            android:src="@drawable/ic_action_ping"
            android:tint="@color/white"/>
    </com.github.jorgecastilloprz.FABProgressCircle>
</android.support.design.widget.CoordinatorLayout>

StephaneBg avatar Jun 17 '15 11:06 StephaneBg

It's not compatible with android.support.design.widget.FloatingActionButton. But it seems work with other floating button library. By the way, I can seem little progress color around floating button when I don't show the FABProgressCircle

luwei2012 avatar Jul 01 '15 02:07 luwei2012

Any solution to this? Or you're using other FAB library?

javiermanzano avatar Jul 06 '15 12:07 javiermanzano

Seems like only compatible with futuresimple/android-floating-action-button. https://github.com/futuresimple/android-floating-action-button

luwei2012 avatar Jul 08 '15 09:07 luwei2012

@ares89 & @StephaneBg : I had the same issue using 'support.design.widget.FloatingActionButton', but adding a 'layout_margin' to my FAB did the trick.

Here is my XML :

  <FrameLayout
        android:id="@+id/frame_layout_gradient"
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:gravity="center"
        android:padding="@dimen/padding_extra_large">


        <com.github.jorgecastilloprz.FABProgressCircle
            android:id="@+id/snap_button_progress_circle"
            android:layout_width="wrap_content"
            android:layout_height="wrap_content"
            app:arcColor="@color/my_primary_dark"
            app:arcWidth="7dp"
            app:finalIcon="@drawable/ic_done_white_48dp">

            <android.support.design.widget.FloatingActionButton
                android:id="@+id/snap_button"
                android:layout_width="230dp"
                android:layout_height="230dp"
                android:layout_margin="35dp"
                android:layout_gravity="end|bottom"
                android:src="@drawable/snap_p" />

        </com.github.jorgecastilloprz.FABProgressCircle>

    </FrameLayout>

maxenceC avatar Jul 08 '15 13:07 maxenceC

I can't see the progressbar at all if i set a custom width/height for the fab


<com.github.jorgecastilloprz.FABProgressCircle
            android:id="@+id/fabProgressCircle"
            android:layout_width="wrap_content"
            android:layout_height="wrap_content"
            app:arcColor="@color/primary_dark"
            app:arcWidth="7dp"
            app:layout_anchorGravity="bottom|right|end">

            <android.support.design.widget.FloatingActionButton
                android:id="@+id/fab"
                android:layout_width="70dp"
                android:layout_height="70dp"
                android:layout_margin="15dp"
                android:clickable="true"
                android:src="@drawable/ic_favorite_white_48dp"
                app:borderWidth="0dp"
                app:layout_anchorGravity="bottom|right|end" />

        </com.github.jorgecastilloprz.FABProgressCircle>

ArthurSav avatar Jul 17 '15 09:07 ArthurSav

Add android:clipChildren="false" to the parent layout. Worked for me.

EDIT: However that seems to leave an ugly orange border in 4.x devices...

Mygod avatar Nov 08 '15 07:11 Mygod

same problem.

GhostFlying avatar Apr 28 '16 08:04 GhostFlying

@ares89 & @StephaneBg please use @maxenceC trick. it works for me too

radityagumay avatar Jun 01 '16 05:06 radityagumay

should close this issues, please :)

radityagumay avatar Jun 01 '16 05:06 radityagumay

I ran across the same issue. The FABProgressCircle works fine, except for some Samsung 4.1 devices, where you still see a clipped outline around your FAB when the progress should be invisible (see image in the first comment).

I was able to fix this issue by rolling back to version 1.0.

I think a bug was introduced in version 1.01 with the implementation of the reusable feature. Setting it to true or false does not fix the bug, so something in the 1.01 code base is at fault.

ajhuntsman avatar Jun 28 '16 13:06 ajhuntsman