TarsosLSH icon indicating copy to clipboard operation
TarsosLSH copied to clipboard

Calculation of CityBlockHash

Open skoppula opened this issue 9 years ago • 1 comments

In families/CityBlockHash.java, you calculate the hash with the following code (line 51):

hash[d] = (int) (vector.get(d)-randomPartition.get(d) / Double.valueOf(w));

I could be wrong here, but would you want parenthesis around the numerator? Otherwise order of operations takes precedence, which I'm not sure is correct.

Thanks. I'd be happy to put in a pull request for you, if need be.

skoppula avatar Mar 26 '16 02:03 skoppula

I sent a pull request for this #14 There is another problem there

joyouskoala avatar Apr 03 '18 22:04 joyouskoala