CommandAPI icon indicating copy to clipboard operation
CommandAPI copied to clipboard

PlayerArgument and OfflinePlayerArgument javadoc should highlight performance issue and potential misuse

Open XHawk87 opened this issue 1 year ago • 0 comments

Description

Following this discussion on Discord

Relating to #586

PlayerArgument and OfflinePlayerArgument have a small performance impact that should be noted in the javadocs, and include a suggestion to use EntitySelectorArgument.OnePlayer instead.

They can also be potentially misused by a malicious player to cause a server to stall by spamming it repeatedly. This risk should be noted, and a suggestion to add appropriate permissions included.

Expected code

No response

Extra details

No response

XHawk87 avatar Aug 09 '24 13:08 XHawk87