Jordi Manyer Fuertes

Results 131 comments of Jordi Manyer Fuertes

> In find it cleaner to get rid of trivial Piola map before going into get_cell_pushforward in general. I agree, I don't like the `isnothing` checks within the routines. We...

I think the `metadata` is already being used? In any case, if this is something all reffes are gonna have, I would probably add it as a new field. It...

@Antoinemarteau is this mergeable? Or do you want to have a look at the last comments?

This might be because off a recent change. In any case, I don't thing this worked anyways for the FullyAssembledRows assembly, since is has jumps (and therefore will always get...

The change I did is the following: https://github.com/gridap/GridapDistributed.jl/pull/180 the `other` section. The idea is that before, `BoundaryTriangulation` was returning the local processor boundary, not the global boundary. I changed it...

> We are not using Boundary(model), but Boundary(model, tags="dirichlet"), and I believe that the tags have always been respecting that of the global model. Ok, then yeah there is no...

@amartinhuertas What version of Gridap are you using? For me, this ```julia using Gridap using FillArrays model = CartesianDiscreteModel((0,1,0,1),(3,3)) trian = BoundaryTriangulation(model,Int[]) reffe = ReferenceFE(lagrangian,Float64,2) V = FESpace(model,reffe) uh =...

Ok, sorry. My bad. I was not checking testitem, just the length of the array.

So here is a little expansion on the above code that reproduces the error: ```julia using Gridap using FillArrays using Gridap.Arrays using Gridap.FESpaces function Arrays.return_value(k::MulAddMap,a,b,c) T = typeof(testitem(a)*testitem(b)+testitem(c)) return zeros(T,size(a,1))...

I think the main issue is that, in the case where arrays are empty, we are not 100% consistent across the code on the sizes of the testitem. As a...