Jordi Masvidal

Results 71 comments of Jordi Masvidal

@hs-oerp the commits for the V17 migration changes should be squashed into only one, currently you have 5. You can check as an example the v18 migration: https://github.com/OCA/stock-logistics-warehouse/pull/2219

@hs-oerp something looks weird in the commit where you run the pre-commit fixes. It looks like you are adding a file pandoc-3.1.13-x86_64-macOS.pkg Could you check?

@GuillemCForgeFlow @MarinaAForgeFlow I think that the picking_policy should not be a commercial field, as you can have different delivery addresses for a customer and maybe the policy for the different...

@OCA/product-maintainers could we get this one merged? :)

@zeroheure thank you for the proposal. Could you change the commit message following the guidelines here (https://github.com/OCA/odoo-community.org/blob/8afdb5a5ebfd3314e2fc836c9b9f644468ee044e/website/Contribution/CONTRIBUTING.rst#L1114)? You mainly need to add '[IMP] product_variant_attribute_name_manager: ...'. Also, pre-commit check is not...

@zeroheure I can see that there are 3 commits all with wrong commit message. You should only have one commit with a message like "[IMP] product_variant_attribute_name_manager: more precise module summary"....

@cuongnmtm could you add #721 in the migration?