Jordan Milne

Results 18 comments of Jordan Milne

:eyeglasses: @JordanMilne @spladug (Feel free to duck out! Just thought this could use some extra C-understanding eyes.)

> I suppose I did it that way to avoid excessive changes to the existing codepaths, as well as to minimize changes the entities themselves IMO not changing the existing...

Yep, that seems sane to me. Only thing is I'd change `is_allowed_named_entity` to something like `resolve_named_entity` now its purpose has changed

I'm going to fuzz this and have someone else take a look to make sure that I didn't miss anything, but other than a couple nits it looks good to...

If the intent is to disable _all_ linking from posts under this new rendering mode we should add testcases to ensure the other forms of links are rendered as plaintext...

💅 Some questions RE how regular links should behave

LGTM, just going to run some fuzz testing to make sure nothing breaks

Yeah, we don't use the ToC renderer, but I don't recall seeing any warnings about it when I last looked. Might be a clang / GCC thing, or maybe it'd...