Jordan Milne

@okyanusoz Thanks for filing an issue! I'm not able to reproduce `advocate.get("http://0177.0.0.1/")` successfully connecting to `localhost` on my system, it raises a validation exception. Are you sure that `advocate.get("http://0177.0.0.1/")` is...

Hi @ColdHeat, sorry for the delay here, unfortunately I haven't had much time to work on OSS recently :disappointed:. I'm in the middle of dropping support for Python 2 as...

Closing since this doesn't appear to be reproducible, please re-open if you have more details that could help reproduce! For future readers, there are several system configurations (like OS X,...

This is strictly a dependency for the tests in CI, and some of the older `requests` versions need something this old.

Haven't looked at the code, but does it know to use `unescape()` for old schemas and `decodeURIComponent()` for new stuff? Stuff that comes out of `escape()` won't necessarily work with...

Agreed, adding type hints would be nice, and easily doable for the Advocate-specific parts of the API. I don't know how it'd work for the more dynamic parts of the...

Hey /u/nandhp, thanks for the PR! The gperf changes look good, but I'm going to have to think about this one a bit. Up until now we've tried to restrict...

@i336 Yep, doing that in gperf would make sense. Right now we're just using gperf to check for membership in a set, but I believe it could be changed to...

Ahhhh, I see what I was missing now. XHTML 1 entities will be output verbatim as before, but HTML5 entities will be output hex-encoded.

Overall, this looks pretty good! My only other thought is that the function's flow is a bit hard to read. Right now it's something like: ``` if is_numeric: if not...