tree-sitter-solidity icon indicating copy to clipboard operation
tree-sitter-solidity copied to clipboard

Feat: include d.ts typings for parser

Open sambacha opened this issue 2 years ago • 3 comments

auto-generated .d.ts file for types also updated dependencies

d.ts was generated using https://github.com/asgerf/dts-tree-sitter

sambacha avatar May 06 '22 23:05 sambacha

this is really cool!

Do you ever need to manually update the generated .d.ts file? If not then I'm thinking we should put this in CI and automatically generate it on every deployment.

WDYT?

JoranHonig avatar May 09 '22 12:05 JoranHonig

this is really cool!

Do you ever need to manually update the generated .d.ts file? If not then I'm thinking we should put this in CI and automatically generate it on every deployment.

WDYT?

Wanted to see your thoughts before adding anything else, was unsure about it. Happy to add it to CI. Can add it this week, additionally will have to add typescript config and versions in case a new version of ts introduces breaking changes/etc and maybe an example of usage

sambacha avatar May 09 '22 12:05 sambacha

Hmm I'm thinking that the types should maybe be part of a separate npm package.

That way the dependencies of the main module stay clean.

JoranHonig avatar May 10 '22 13:05 JoranHonig