Jorge Turrado Ferrero

Results 900 comments of Jorge Turrado Ferrero

I'm not an expert on that scaler, but based on docs, users don't have any parameter to provide metric name, I guess that's because the scaler doesn't need that information...

I think atm that field it's not documented but I'm willing to open a PR adding the field to the exported metrics and also documenting. could this solve the issue?

> I do agree regex has its place, but maybe we need both? (list + regex?) For me, regex is totally enough, it's the approach we have in RabbitMQ, but...

> I'll add it. Should we cover for both queue and subscriber cases? (I don't mind adding them, I am just thinking about how the test suite size). If possible,...

let's wait till the SDK update is merged (sorry for the extra work :( )

I didn't touch the eventhub sdk, only the service-bus sdk which I'd say is different

I have checked the SDK for this and, oh surprise, [uses other authentication mechanism](https://pkg.go.dev/github.com/Azure/azure-storage-blob-go/azblob#TokenCredential) different from the service-bus SDK... Maybe in the future they unify the SDK in a single...

> > I didn't touch the eventhub sdk, only the service-bus sdk which I'd say is different > > I thought you upgraded it to v3, which is why I...

did you mean with [this PR](https://github.com/kedacore/keda/pull/3639)? I only changed the service-bus sdk ![image](https://user-images.githubusercontent.com/36899226/190220698-abd33a06-1aa6-4a2e-ba27-3c014315af1b.png) others are minor versions