MMM-Remote-Control icon indicating copy to clipboard operation
MMM-Remote-Control copied to clipboard

Non-Substantive recommendations from MagicMirror devs

Open dathbe opened this issue 1 year ago • 0 comments

OS

NA

NodeJS Version

NA

MagicMirror² Version

NA

Remote Control Version

NA

Did you try using just Remote Control alone with MM?

  • [X] I have and the error still happening

Description

The devs have run checks on 3rd party modules and made some recommendations. For Remote-Control, they are here https://github.com/KristjanESPERANTO/MagicMirror-3rd-Party-Modules/blob/main/result.md#MMM-Remote-Control-by-Jopyth

I was going to create a PR for the recommendations where I can, but there's scary warning text in the PR page for this repository, and a bunch of stale PRs, so I backed off. Here are the changes, in summary:

  • Replace references to the MichMich/MagicMirror repository with the new MagicMirrorOrg/MagicMirror repository. I have done that at https://github.com/dathbe/MMM-Remote-Control
  • Replace references to "Magic Mirror" and "MagicMirror" with "MagicMirror²". I have done this in my fork above.
  • Replace New Date() with New new Date(Date.now()). Done in my fork.
  • The devs suggest using ESLint instead of jshint. (not something I'm familiar with).
  • Replaced node-fetch and XMLHttpRequest with fetch. More involved than I've been able to look into.
  • For some reason it's not picking up that there is an "Update" section in the README.
  • it doesn't like that there's a reference to omxplayer in modules.json, but this does not seem like an actual problem.

Note: They also recommend changing the name of the primary branch, but that would mess up git pull updates.

Expected behavior

No change

Current behavior

No change

Possible solution

Partial: https://github.com/dathbe/MMM-Remote-Control

Steps to reproduce

N/A

Log

N/A

config.js

N/A

Additional info

No response

dathbe avatar Mar 25 '24 20:03 dathbe