Jonathan Plasse
Jonathan Plasse
- #3302
> Hey, > > `python-use-type-annotations` is marked as implemented in the OP. But it isn't, is it? thinking > > fin swimmer > * [Add flake-pyi PYI033 "Do not use...
I vote for `PYE` as it would keep the same categories and the migration would be easier.
mypy has `junit_xml = "reports/mypy.xml"` in `pyproject.toml`. pytest has `--junitxml=reports/pytest.xml"` in the CLI. I would propose `--junit-xml` in the CLI and `junit-xml` in `pyproject.toml`. Only the Junit format interest me.
I found an alternative; I skip Ruff in pre-commit with: ```shell SKIP=ruff pre-commit run --all-files ``` then run ```shell ruff --format=junit > reports/ruff.xml ``` But I still think it could...
Should it be auto-generated like in #1015?
All type comments can be replaced (c.f.: https://peps.python.org/pep-0526/#where-annotations-aren-t-allowed) ```python from types_aiobotocore_s3 import S3ServiceResource async with self.boto_session.resource("s3") as s3: # type: S3ServiceResource obj = await s3.Object(self.bucket_name, key) return (await obj.get())["Body"] #...
We could use [pre-commit.ci](https://pre-commit.ci/) that would run on pull-request to do this.
Dev generate all will generate the different file which will be then formated by prettier. Pre-commit will always fail at the one of the hook as the output of prettier...
I added prettier in pre-commit. I had to: - Ignore formatting for the table (c.f. prettier/prettier-vscode#762) - Use `-` as bullet as prettier does not support `*` bullet (c.f. prettier/prettier#4440)....