scenic-view icon indicating copy to clipboard operation
scenic-view copied to clipboard

Event tracing fails because of missing modules open

Open credmond opened this issue 1 year ago • 1 comments

Caused by: java.lang.IllegalAccessException: module javafx.base cannot access class org.scenicview.view.tabs.EventLogTab$ScenicViewEvent (in module org.scenicview.scenicview) because module org.scenicview.scenicview does not open org.scenicview.view.tabs to javafx.base
        at [email protected]/com.sun.javafx.property.MethodHelper.invoke(Unknown Source)
        ... 57 more

I think ScenicView is missing other "opens" too for itself (org.scenicview.view.xxx) -- I recall some stacktraces in the past.

For a standalone UI like this, I don't really see the point in worrying about individual opens -- just use a global open module, especially since there doesn't appear to be any tests to find these types of issues.

credmond avatar Feb 05 '24 19:02 credmond

Fixed in this PR: https://github.com/JonathanGiles/scenic-view/pull/82

credmond avatar Feb 05 '24 20:02 credmond