vue-toggle-btn
vue-toggle-btn copied to clipboard
JonathanDn
use parent events and value on checkbox
- allows user to use "v-model" with all it's modifiers (because value binding and all related events are valid).
- reduce code, because now the component doesn't need to emit the change event manually.
- specify props types.
- add ability to add "name" attribute to the checkbox - needed for some forms.
-
I do not really see a use case for this. There is no point in passing to the toggle button a string it only is supposed to receive a boolean - isActive
-
Working with Input value instead of isActive is interesting, Could you elaborate on what value the $listeners provides, what does it do?
3 is perfectly clear and I agree on it being a better addition.
- Can you elaborate on this, why should I need a name attribute - for accessibility?
-
I changed the "isActive" to "value" because when you use "value" prop name - you can also pass it as v-model, so users can use this component using "v-model".
-
you don't need to manage the input events and triggers at all. The user can register to all of the input native events, such as focus, change, input, etc.. Also, when users are using "v-model", they expecting the "input" or "change" events (depends if they are using "lazy" modifier or not).
-
thanks.
-
the "name" is used for native html forms. There are several cases that it's recommended to add name attribute to inputs.
Alright so to wrap up:
-
isActive is changed to value prop (please update the readme documentation according)
-
because of that change consumers of the component can now use v-model - (Can you think of where in the documentation this information would be useful, maybe as a code example? if so feel free to add it to the readme)
-
The docs are addressing the custom events - please adjust them to the relevant 'input' and 'change' events so it would be clear for consumers of the component.
-
same about 'name' prop now exposed as part of the API - needs to be documented.