timetable icon indicating copy to clipboard operation
timetable copied to clipboard

Migrate to null-safety

Open TatsuUkraine opened this issue 3 years ago • 7 comments

Everything is in title)

TatsuUkraine avatar Nov 22 '20 18:11 TatsuUkraine

Migration to null-safety is currently blocked by the following (direct & transitive) dependencies not supporting null safety yet:

  • [ ] black_hole_flutter: JonasWanke/black_hole_flutter#1
  • [ ] dartx: leisim/dartx#112
  • [x] crypto: dart-lang/crypto#105
  • [ ] time_machine: Dana-Ferguson/time_machine#50

JonasWanke avatar Dec 03 '20 12:12 JonasWanke

@JonasWanke would it be possible to unsound null safety to do a partial migration, I wonder?

IoanaAlexandru avatar Dec 31 '20 12:12 IoanaAlexandru

@IoanaAlexandru As crypto has published a null-safe version two days ago (unblocking dartx) and there's an open PR for time_machine, I'd rather wait for a few more days, hoping we'll be unblocked very soon.

JonasWanke avatar Jan 01 '21 09:01 JonasWanke

dartx seems to be done black_hole_flutter's PR is closed too time_machine seems to be abandoned

vendelin8 avatar Mar 05 '21 08:03 vendelin8

Sorry for the delay and for not keeping this up-to-date. I've recently started the rewrite originally proposed in #17, and as part of this rewrite, also migrated to null-safety and dropped time_machine and dartx dependencies (which wasn't migrated at the time). This rewrite isn't done yet, but I've already managed to overcome the major blockers (visible as layout overflows in the old app).

JonasWanke avatar Mar 05 '21 10:03 JonasWanke

Hi. Does the work continue? Is there anything I can help with

mcagrigoktas avatar Apr 08 '21 20:04 mcagrigoktas

The work continues, but, unfortunately, quite slowly due to time constraints. I've posted an update here: https://github.com/JonasWanke/timetable/issues/17#issuecomment-822645067. I'll try to get the API stable and release a new version very soon. After that, contributions are very welcome!

JonasWanke avatar Apr 19 '21 17:04 JonasWanke