fix: conditionally reveal metadata when using defaultDirectives
- Quick Checklist
- [x] I have read the contributing guidelines
- [x] I have written new tests, as applicable (for bug fixes / features)
- [ ] ~~Docs have been added / updated (for bug fixes / features)~~
- [x] I have added a changeset, if applicable
-
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) Fixes the conditional reveal of metadata when using the
defaultDirectivesoption. -
~~What is the new behavior (if this is a feature change)?~~
-
~~Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)~~
-
Other information: Should fix issue #355.
🦋 Changeset detected
Latest commit: 2de8e1f2ede33bbc0685b2ac1880810929a29a11
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 2 packages
| Name | Type |
|---|---|
| rollup-plugin-imagetools | Minor |
| vite-imagetools | Minor |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Codecov Report
Merging #357 (2de8e1f) into main (0ffa4c0) will not change coverage. The diff coverage is
100.00%.
@@ Coverage Diff @@
## main #357 +/- ##
=======================================
Coverage 94.47% 94.47%
=======================================
Files 30 30
Lines 434 434
Branches 111 111
=======================================
Hits 410 410
Misses 24 24
| Flag | Coverage Δ | |
|---|---|---|
| imagetools-core | 97.64% <ø> (ø) |
|
| rollup-plugin-imagetools | 98.30% <100.00%> (ø) |
|
| vite-imagetools | 79.48% <100.00%> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| packages/rollup/src/index.ts | 98.30% <100.00%> (ø) |
|
| packages/vite/src/index.ts | 79.48% <100.00%> (ø) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@JonasKruckenberg do you think it might be worth a preset example in the docs for
defaultDirectives?
Sure yeah!
@ElMassimo I just came across your
vite-plugin-image-presetsshortly before coming across this PR. Not sure if it might be worth using this for Iles and teaming up on having a single great image handling Vite plugin?
I think there is space enough for multiple image plugins in the site ecosystem :wink: especially since I don't have the time to maintain even more functionality without help here 😟
That said though, we should maybe check if our plugins could be made compatible if they aren't already!
Better late than never - thanks!