JGProgressHUD icon indicating copy to clipboard operation
JGProgressHUD copied to clipboard

Published 20 hours ago • verified publisher icon JonasGessner

Improve UI testability

Open lechuckcaptain opened this issue 4 years ago • 3 comments

It should be easier to interact with JGProgressHUD during UI tests.

I added a very basic sample Swift UI test project and some basics accessibilityIdentifier to some relevant things of JGProgressHUD.

It's just a basic proof of concept (I'm really not an expert of Objective-C) in order to make you understand the idea, I'm sure there is plenty of space for improvement.

lechuckcaptain avatar Oct 15 '19 08:10 lechuckcaptain

Hey, thanks for the PR! This looks pretty good, but without any concrete tests beyond a PoC this is not something I'd want on master. To be honest I wouldn't add any UI tests myself anytime soon, so unless you are planning on adding more tests I'd go ahead and close this PR.

JonasGessner avatar Jun 19 '20 17:06 JonasGessner

I'll try to add some tests. Keep the PR open please.

lechuckcaptain avatar Jun 19 '20 19:06 lechuckcaptain

Hey @JonasGessner, please have a look at the updated PR. I added a more meaningful UI test for the Swift app. I can add more tests, but it would require to expand the Swift app example with more feature or to test the Obj-C app.

If you are not willing to consinder the PR, please at least keep (or add new) accessibilityIdentifier(s) to the HUD views.

Thanks!

lechuckcaptain avatar Jun 26 '20 15:06 lechuckcaptain