JGActionSheet icon indicating copy to clipboard operation
JGActionSheet copied to clipboard

Published 20 hours ago • verified publisher icon JonasGessner

Implemented "showFromRect:inView:animated:"

Open michaeltyson opened this issue 9 years ago • 6 comments

Hi! This adds the ability to select an origin rect, and have JGActionSheet automatically determine which side to display on. This mirrors the functionality from UIActionSheet.

michaeltyson avatar Nov 16 '15 05:11 michaeltyson

Awesome, this is something I wanted to implement a long time ago. I'll test it when I get some free time but it looks promising! Wicked!

JonasGessner avatar Nov 17 '15 00:11 JonasGessner

Cool =)

michaeltyson avatar Nov 17 '15 01:11 michaeltyson

Just added an additional commit that provides the "moveToRect" functionality necessary when rotating

michaeltyson avatar Nov 18 '15 07:11 michaeltyson

I would love to get this pull-requested merged and the pod updated. Thanks @michaeltyson for implementing it.

tposch avatar Jan 07 '16 16:01 tposch

Thanks for reminding me. I'm super busy but I hope that I will be able to test this soon.

JonasGessner avatar Jan 07 '16 23:01 JonasGessner

Ah, the downside of getting pull requests - yet another thing to add to the todo list =) I've always got a backlog on my projects.

michaeltyson avatar Jan 07 '16 23:01 michaeltyson