Jon Rowe

Results 306 comments of Jon Rowe

Ah JRuby, I haven't missed your quirks, is this something thats happening only on the current head? Why haven't our builds caught it @pirj?

Care to add an example to our build that fails as a draft as a first step?

Closing due to inactivity / lack of a reproduction during the monorepo migration.

Some further improvements could be made here,what happens when used positionally? and does it always mean the supplied `&block` argument? After all `object.msg(proc {}, proc {})` is valid Ruby, should...

@ioquatix We already have that, it's called `and_yield`, e.g. `expect(thing).to receive(:method).and_yield`

You are welcome to have a go at refactoring it if you think you can make it better, please make sure you understand the matcher protocol before changing method names,...

They're not different enough, and can be passed around... Consider: ``` 2.5.1 :001 > def a(&block) 2.5.1 :002?> puts block.inspect 2.5.1 :003?> block 2.5.1 :004?> end => :a 2.5.1 :005...

I'm not sure why this was never merged, migrated to the monorepo as rspec/rspec#114

Green bar jruby which is failing due to unrelated reasons, care to re-review @myronmarston ?