heimdall-rs icon indicating copy to clipboard operation
heimdall-rs copied to clipboard

feat(snapshot): post-processing outputs

Open solidoracle opened this issue 1 year ago • 5 comments

fixes https://github.com/Jon-Becker/heimdall-rs/issues/177

solidoracle avatar Nov 27 '23 13:11 solidoracle

I'll take a look tonight!

Jon-Becker avatar Nov 27 '23 16:11 Jon-Becker

good start! there are still a few conditionals slipping through :)

image

Jon-Becker avatar Nov 28 '23 01:11 Jon-Becker

good start! there are still a few conditionals slipping through :)

image

In these expressions there are an odd number of parenthesis, so the find_balanced_encapsulator is not finding the closing one. I've pushed a temporary fix removing the initial odd parenthesis, and added test_double_negation to share my thinking. Let me know your thoughts. Ignore the println, will remove once finalised @Jon-Becker

solidoracle avatar Dec 05 '23 16:12 solidoracle

Sounds good! i'll review tonight :)

Jon-Becker avatar Dec 06 '23 20:12 Jon-Becker

pending #290 :)

ill tackle soon!

Jon-Becker avatar Feb 09 '24 16:02 Jon-Becker

closing as snapshot is being removed in 0.8.0, as its just a simplified decompile

Jon-Becker avatar May 07 '24 18:05 Jon-Becker