joinmarket icon indicating copy to clipboard operation
joinmarket copied to clipboard

skip empty change addresses for makers

Open adlai opened this issue 9 years ago • 7 comments

works towards #418 but does not enable this behavior maker-side; that would require recognizing when a subset of utxos match the cjout size precisely, and short-circuiting past the addition of a dust amount.

adlai avatar Feb 10 '16 13:02 adlai

I have read the diff and I think it's not wrong.

chris-belcher avatar Feb 10 '16 15:02 chris-belcher

Could someone else have a look at this before we merge, it contains modifications to verify_unsigned_tx() which is quite important for making sure all the coins go to where they should.

chris-belcher avatar Mar 08 '16 23:03 chris-belcher

Taking a look now, will feed back if I have a comment.

AdamISZ avatar Mar 09 '16 12:03 AdamISZ

We can surely merge this now?

chris-belcher avatar Apr 10 '16 15:04 chris-belcher

This should be merged, as it addresses #27 which is required by #171

adlai avatar Jul 14 '16 12:07 adlai

Coverage Status

Coverage increased (+0.05%) to 79.916% when pulling 226bcf84bf83b66ceebbb2aa7cc7e456ca8ad20d on adlai:sweep-empty-change into f3afd81dc84633acfc83de753879f49d31520066 on JoinMarket-Org:develop.

coveralls avatar Jul 16 '16 09:07 coveralls

Coverage Status

Coverage increased (+0.003%) to 78.117% when pulling 855c8663d1205f595f1e8ec8f23ea0950dd59d51 on adlai:sweep-empty-change into 46fe3e8bbe9bbc769db1732029e90db9591fe8d5 on JoinMarket-Org:develop.

coveralls avatar Oct 03 '17 09:10 coveralls