JoinMarket-Org
configurable thresholds for utxo merge policies
Untested but I agree with it.
Aside: The comments in the default joinmarket.cfg file seem to be getting quite large and wordy, I wonder if it's worth documenting the options on the wiki instead, with only a link in .cfg
Bikeshed: the default threshold should be higher for privacy IMO. Use bitcoin.select() up to about 30 UTXOs, switch to gradual around 40, greedy at 50 and greediest at 60+. My yield generator wallet has about 65 UTXOs if anyone is wondering. Having lots of UTXOs is great for privacy, its like owning a total of 20,000 CHF in a mixture of banknote sizes from 5 CHF all the way up to 1000 CHF notes. Spending them leaks a lower bound of your balance.
Has anyone tried this yet? It could be used on someone's yield generator.
I'd say lets merge this into develop and just fix it if it crashes when being used, develop is allowed to be slightly unstable.
I'd say lets merge this into develop and just fix it if it crashes when being used, develop is allowed to be slightly unstable.
I sort of agree, but I just wrote #496 and I think it applies here. If we want to make a new release, is it needed to add this?
If it is, please provide test coverage of some sort.
Yes fair enough, write a test
This is still worth merging as a default because JoinMarket takers dont really have a way to handle very large amounts of UTXOs yet so this would be good to help prevent them happening in the first place.
rebased onto current develop. travis failure is mysteriously inscrutable, to me at least.
test pending.
@adlai Looks like a circular dependency because you imported bitcoin into support.py
Coverage increased (+0.2%) to 77.473% when pulling 76567cd86590547e16c77d2a44d1af3d43b3b53a on adlai:merge-policies into 8c2b6d83dfddb85451d185e64f0fe4df62d5c54e on JoinMarket-Org:develop.
Coverage increased (+0.2%) to 77.503% when pulling 3b3bca9f45cbde3113044810d938d86ab50404f4 on adlai:merge-policies into 8c2b6d83dfddb85451d185e64f0fe4df62d5c54e on JoinMarket-Org:develop.
Coverage increased (+0.2%) to 77.488% when pulling 3b3bca9f45cbde3113044810d938d86ab50404f4 on adlai:merge-policies into 8c2b6d83dfddb85451d185e64f0fe4df62d5c54e on JoinMarket-Org:develop.
Coverage increased (+0.4%) to 78.552% when pulling 099973b141d652bf0b2fa9b7970007959d021531 on adlai:merge-policies into 46fe3e8bbe9bbc769db1732029e90db9591fe8d5 on JoinMarket-Org:develop.
Coverage increased (+0.4%) to 78.49% when pulling 729df6c92ff06336199437fced8ae83ab1c96263 on adlai:merge-policies into 46fe3e8bbe9bbc769db1732029e90db9591fe8d5 on JoinMarket-Org:develop.
Coverage increased (+0.4%) to 78.552% when pulling 729df6c92ff06336199437fced8ae83ab1c96263 on adlai:merge-policies into 46fe3e8bbe9bbc769db1732029e90db9591fe8d5 on JoinMarket-Org:develop.