joinmarket-clientserver icon indicating copy to clipboard operation
joinmarket-clientserver copied to clipboard

Refactor: use term "passphrase" instead of "password" for JM wallets everywhere, for consistency

Open kristapsk opened this issue 2 years ago • 6 comments

Re-opened and rebased #916 (I accidentally deleted my JM forked repo, could not figure out how to rebase in that PR).

kristapsk avatar Jul 28 '21 16:07 kristapsk

Do we allow spaces in passwords/phrases? I always found 'password' unambiguous based on the idea it's one word. That's to me, why 'seedphrase' is correct, because it's 12/24/whatever words.

AdamISZ avatar Sep 06 '21 13:09 AdamISZ

Do we allow spaces in passwords/phrases?

Yes, we do.

kristapsk avatar Sep 06 '21 14:09 kristapsk

Rebased.

kristapsk avatar Sep 06 '21 14:09 kristapsk

In reviewing this again, I'm still not comfortable with it. Try ddg-ing "password vs passphrase".

As far as I can tell, passphrase has almost universally been used to specifically refer to multi-word passphrases.

Here's one of the first results I get: https://protonmail.com/blog/protonmail-com-blog-password-vs-passphrase/

AdamISZ avatar Oct 17 '21 14:10 AdamISZ

We allow multi-word passphrases and term "passphrase" in already used UI, this just makes it consistent accross codebase.

kristapsk avatar Oct 17 '21 15:10 kristapsk

Rebased.

kristapsk avatar Mar 03 '22 12:03 kristapsk