joinmarket-clientserver
joinmarket-clientserver copied to clipboard
Refactor: use term "passphrase" instead of "password" for JM wallets everywhere, for consistency
Re-opened and rebased #916 (I accidentally deleted my JM forked repo, could not figure out how to rebase in that PR).
Do we allow spaces in passwords/phrases? I always found 'password' unambiguous based on the idea it's one word. That's to me, why 'seedphrase' is correct, because it's 12/24/whatever words.
Do we allow spaces in passwords/phrases?
Yes, we do.
Rebased.
In reviewing this again, I'm still not comfortable with it. Try ddg-ing "password vs passphrase".
As far as I can tell, passphrase has almost universally been used to specifically refer to multi-word passphrases.
Here's one of the first results I get: https://protonmail.com/blog/protonmail-com-blog-password-vs-passphrase/
We allow multi-word passphrases and term "passphrase" in already used UI, this just makes it consistent accross codebase.
Rebased.