joinmarket-clientserver icon indicating copy to clipboard operation
joinmarket-clientserver copied to clipboard

Add Snap package configuration

Open dmp1ce opened this issue 4 years ago • 5 comments

Provides a Snap configuration which produces a .snap file which can be uploaded to the Snapcraft store. This repository can also be linked to the Snapcraft build system for automatic builds.

A bash scripts wraps some the JoinMarket script functionality. The QT GUI is run by default.

dmp1ce avatar Feb 05 '20 20:02 dmp1ce

@takinbo I don't have a way of running tests which require bitcoind from within the Snap build process. I could possibly expose the test scripts so they could be run be the user once the snap is installed. I'm not sure that would be valuable to anyone.

dmp1ce avatar Feb 07 '20 22:02 dmp1ce

Does anyone else have any thoughts on this? @AlexCato @undeath @kristapsk @chris-belcher @jameshilliard for example?

AdamISZ avatar May 08 '20 14:05 AdamISZ

Have no experience with that Snap thing. What I don't like is polluting root directory of JM with too much files / directories. Can't we move it to contrib/snap or something like that? There could be a lot of different package managers and other stuff one might want to add support.

kristapsk avatar May 08 '20 16:05 kristapsk

What are the advantages of snap over the docker images we already have? I guess Qt support?

Other than that I second @kristapsk idea about having a contrib/ dir.

undeath avatar May 08 '20 16:05 undeath

I can work on putting the files in contrib/. The advantages of the Snap would be GUI support, process containment with AppArmour and automatic updates if installed through the Snapcraft store.

dmp1ce avatar May 08 '20 20:05 dmp1ce