Directory nodes constantly disconnecting

[PulpCattel]

EDIT: as per https://github.com/JoinMarket-Org/joinmarket-clientserver/pull/1436#issuecomment-1399480855, the spam issue should be mostly solved. Renamed this issue to focus on the "disconnect" part. Hopefully the changes in #1436 will improve this already.

EDIT: g3hv4uynnmynqqq2mchf3fcm3yd46kfzmcdogejuckgwknwyq5ya6iad is constantly disconnecting too now.

As reported by many different users and contributors, the following two directory nodes are disconnecting in a repetitive/constant pattern:

• 3kxw6lf5vf6y26emzwgibzhrzhmhqiw6ekrek3nqfjjmhwznb2moonad.onion:5222
• bqlpq6ak24mwvuixixitift4yu42nxchlilrcqwk2ugn45tdclg42qid.onion:5222

The log is simply a constant repetition of:

[DEBUG]  We got a disconnect event: 3kxw6lf5vf6y26emzwgibzhrzhmhqiw6ekrek3nqfjjmhwznb2moonad.onion:5222
[INFO ]  Updating status to connected for peer 3kxw6lf5vf6y26emzwgibzhrzhmhqiw6ekrek3nqfjjmhwznb2moonad.onion:5222.

It started last week from what I can gather from users report, but I can't confirm it wasn't happening earlier too. At this point, it seems plausible to me this is a bug in our code logic.

The simplest explanation that comes to my mind is that we are not handling correctly some connectivity issue edge case.

Curiously, the newly added directory node g3hv4uynnmynqqq2mchf3fcm3yd46kfzmcdogejuckgwknwyq5ya6iad.onion:5222 is unaffected. This node is not yet in a release, so it might simply be because of less network traffic (EDIT: this directory is now experiencing exactly the same problem).

FWIW, signet directories also appear to be working.

This issue might resolve itself, but IMHO it's good to look into it to prevent it from happening again.