joinmarket-clientserver icon indicating copy to clipboard operation
joinmarket-clientserver copied to clipboard

Improve orderbook human readability

Open GordianLN opened this issue 1 year ago • 7 comments

As someone used to running a LN routing node, I am accustomed to LN notation of 1_234_567 to represent 1234567sats, or 0.01234567BTC. Also, all my accounting script reports are in monospace fonts, easy to pad.

Consider this: image

I believe it would be trivial on one side, and on the other, greatly improve the way users can gauge the OB, if:

  • ppm value was rounded to 2 decimals (or none, since we're at it)
  • every satoshi amount was formatted as 1_234_567
  • every number cell was in monospace font

GordianLN avatar Aug 16 '22 14:08 GordianLN

To additionally motivate the request: I understand this is but a minor addition, yet JM comes from a place where it's "the hard and complex alternative to samourai and wasabi (eugh)", and any little effort spent in making the experience better for the end users I think would greatly improve its potential adoption. For the programmer who coded the OB backend in the first place, such edits should be a piece of cake, and immediately make the OB way more friendly at a glance to the whole population of LN operators, for example.

GordianLN avatar Aug 16 '22 14:08 GordianLN

As someone used to running a LN routing node, I am accustomed to LN notation of 1_234_567 to represent 1234567sats

Which software does _ as a thousands separator for sats?

any little effort spent in making the experience better for the end users I think would greatly improve its potential adoption

Agree on this!

kristapsk avatar Aug 16 '22 14:08 kristapsk

Which software does _ as a thousands separator for sats?

Know what? I wouldn't be able to tell you for sure anymore, I believe it was a notation used by ThunderHub? RTL? Just around plebnet groups? Since my very first few days after experimenting with GUIs, I've always worked with CLI and took up the _ separator for thousands as specific for lightning. I'm okay with any separator obviously, as long as it's monospace and makes the 1234567890 numbers easier on the eyes, after all JM is not about LN 🙂

GordianLN avatar Aug 17 '22 07:08 GordianLN

Definitely not RTL, I'm using that myself.

kristapsk avatar Aug 17 '22 08:08 kristapsk

Definitely not RTL, I'm using that myself.

Confirmed here. Additionally, I have never seen _ used as a thousands separator, either in Lightning software, Bitcoin software or anywhere else. Of course it may well depend on locale, perhaps it is used somewhere.

AdamISZ avatar Aug 17 '22 08:08 AdamISZ

Ok you're now making me feel like "the crazy one", I know I picked it up back when I started lurking in plebnet... no matter where it came from though, I'd say a thousands separator, however you want to choose it, would be a welcome addition, no?

GordianLN avatar Aug 26 '22 16:08 GordianLN

I'd say a thousands separator, however you want to choose it, would be a welcome addition, no?

I'd probably agree there. Albeit it's not too important. PRs welcome from anyone on that.

AdamISZ avatar Aug 27 '22 11:08 AdamISZ