joinmarket-clientserver icon indicating copy to clipboard operation
joinmarket-clientserver copied to clipboard

Building local Tor sometimes fails at test phase

Open kristapsk opened this issue 2 years ago • 2 comments

When doing ./install.sh --with-local-tor, it sometimes fails at test phase.

PASS: src/test/test_workqueue
./test-driver: line 109: 23325 Aborted                 "$@" > $log_file 2>&1
FAIL: src/test/test-slow
PASS: src/test/test-timers
============================================================================
Testsuite summary for tor 0.4.6.8
============================================================================
# TOTAL: 33
# PASS:  25
# SKIP:  7
# XFAIL: 0
# FAIL:  1
# XPASS: 0
# ERROR: 0
============================================================================
See ./test-suite.log
============================================================================
FAIL: src/test/test-slow
========================

slow/crypto/s2k_rfc2440: OK
slow/crypto/s2k_pbkdf2: OK
slow/crypto/s2k_rfc2440_general: OK
slow/crypto/s2k_rfc2440_legacy: OK
slow/crypto/s2k_errors: OK
slow/crypto/scrypt_vectors: SKIPPED
slow/crypto/pbkdf2_vectors: OK
slow/crypto/pwbox: OK
slow/crypto/fuzz_donna/ed25519_donna: [forking] OK
slow/crypto/fuzz_donna/ed25519_ref10: [forking] OK
slow/process/callbacks: OK
slow/process/callbacks_terminate: OK
slow/process/nonexistent_executable: Apr 10 18:13:20.676 [err] tor_assertion_failed_(): Bug: src/core/mainloop/mainloop.c:741: shutdown_did_not_work_callback: Assertion line should be unreached failed; aborting. (on Tor 0.4.6.8 )
Apr 10 18:13:20.678 [err] Bug: Tor 0.4.6.8: Assertion line should be unreached failed in shutdown_did_not_work_callback at src/core/mainloop/mainloop.c:741: . Stack trace: (on Tor 0.4.6.8 )
Apr 10 18:13:20.678 [err] Bug:     ./src/test/test-slow(log_backtrace_impl+0x57) [0x5585f2d7fbd7] (on Tor 0.4.6.8 )
Apr 10 18:13:20.678 [err] Bug:     ./src/test/test-slow(tor_assertion_failed_+0x148) [0x5585f2d8ccc8] (on Tor 0.4.6.8 )
Apr 10 18:13:20.678 [err] Bug:     ./src/test/test-slow(+0x170446) [0x5585f2d40446] (on Tor 0.4.6.8 )
Apr 10 18:13:20.678 [err] Bug:     /usr/lib64/libevent-2.1.so.7(+0x21c02) [0x7fde98bf6c02] (on Tor 0.4.6.8 )
Apr 10 18:13:20.678 [err] Bug:     /usr/lib64/libevent-2.1.so.7(event_base_loop+0x4c7) [0x7fde98bf78b7] (on Tor 0.4.6.8 )
Apr 10 18:13:20.678 [err] Bug:     ./src/test/test-slow(+0x170d99) [0x5585f2d40d99] (on Tor 0.4.6.8 )
Apr 10 18:13:20.678 [err] Bug:     ./src/test/test-slow(run_main_loop_until_done+0x35) [0x5585f2d447a5] (on Tor 0.4.6.8 )
Apr 10 18:13:20.678 [err] Bug:     ./src/test/test-slow(+0x74a0e) [0x5585f2c44a0e] (on Tor 0.4.6.8 )
Apr 10 18:13:20.678 [err] Bug:     ./src/test/test-slow(+0x74f08) [0x5585f2c44f08] (on Tor 0.4.6.8 )
Apr 10 18:13:20.678 [err] Bug:     ./src/test/test-slow(+0x8cef8) [0x5585f2c5cef8] (on Tor 0.4.6.8 )
Apr 10 18:13:20.678 [err] Bug:     ./src/test/test-slow(testcase_run_one+0x74) [0x5585f2c5cfd4] (on Tor 0.4.6.8 )
Apr 10 18:13:20.678 [err] Bug:     ./src/test/test-slow(tinytest_main+0x104) [0x5585f2c5d854] (on Tor 0.4.6.8 )
Apr 10 18:13:20.678 [err] Bug:     ./src/test/test-slow(main+0x48b) [0x5585f2c4018b] (on Tor 0.4.6.8 )
Apr 10 18:13:20.678 [err] Bug:     /lib64/libc.so.6(__libc_start_main+0xce) [0x7fde986bf7fe] (on Tor 0.4.6.8 )
Apr 10 18:13:20.678 [err] Bug:     ./src/test/test-slow(_start+0x2a) [0x5585f2c402ca] (on Tor 0.4.6.8 )
FAIL src/test/test-slow (exit status: 134)

Can others reproduce this? Unless it's something specific with my setup, this could be blocker for enabling local Tor by default. One workaround could be to not run Tor test suite, but I would not be too happy with that.

kristapsk avatar Apr 10 '22 15:04 kristapsk

I tried again (I did test install for the PR too) on my machine, I see no failures (although there are skips):

make[2]: Entering directory '...joinmarket-clientserver/deps/tor-0.4.6.8'
SKIP: src/test/fuzz_static_testcases.sh
SKIP: src/test/test_key_expiration.sh
SKIP: src/test/test_keygen.sh
SKIP: src/test/test_zero_length_keys.sh
SKIP: src/test/test_switch_id.sh
PASS: src/test/test_cmdline.sh
PASS: src/test/test_parseconf.sh
PASS: src/test/test_workqueue_efd.sh
PASS: src/test/test_workqueue_socketpair.sh
PASS: src/test/test_workqueue_pipe2.sh
PASS: src/test/test_workqueue_efd2.sh
PASS: src/test/test_workqueue_cancel.sh
PASS: src/test/test_workqueue_pipe.sh
PASS: src/test/unittest_part2.sh
PASS: src/test/test_ntor.sh
PASS: src/test/test_hs_ntor.sh
PASS: src/test/test_bt.sh
PASS: scripts/maint/practracker/test_practracker.sh
PASS: scripts/maint/run_check_subsystem_order.sh
SKIP: src/test/test_rebind.sh
SKIP: src/test/test_include.sh
PASS: src/test/unittest_part8.sh
PASS: scripts/maint/checkSpaceTest.sh
PASS: src/test/test-memwipe
PASS: src/test/test_workqueue
PASS: src/test/unittest_part1.sh
PASS: src/test/unittest_part3.sh
PASS: src/test/unittest_part4.sh
PASS: src/test/unittest_part6.sh
PASS: src/test/unittest_part7.sh
PASS: src/test/unittest_part5.sh
PASS: src/test/test-slow
PASS: src/test/test-timers
============================================================================
Testsuite summary for tor 0.4.6.8
============================================================================
# TOTAL: 33
# PASS:  26
# SKIP:  7
# XFAIL: 0
# FAIL:  0
# XPASS: 0
# ERROR: 0
============================================================================

ubuntu 20.04.3 LTS

AdamISZ avatar Apr 10 '22 19:04 AdamISZ

It does not happen always, from time time to time. When I retry, it always succeeds.

kristapsk avatar Apr 10 '22 19:04 kristapsk

Closing this, I don't remember having this problem for a long time. And no similar reports from others.

kristapsk avatar May 04 '23 00:05 kristapsk