joinmarket-clientserver icon indicating copy to clipboard operation
joinmarket-clientserver copied to clipboard

Published 20 hours ago • verified publisher icon JoinMarket-Org

Don't pin cryptography to a specific version for macOS

Open kristapsk opened this issue 2 years ago • 1 comments

Should fix #1139. @ChzenChzen could you test?

kristapsk avatar Feb 16 '22 20:02 kristapsk

This could potentially introduce Rust as a new depdency, which probably then needs to be added to install.sh for Mac, but not sure about that.

kristapsk avatar Feb 16 '22 20:02 kristapsk

So given that #1398 has been merged, does that mean we don't really want to do this? Perhaps try to solve it another way? Or, given the positive result of #1412 can we say it is not needed?

AdamISZ avatar Dec 27 '22 10:12 AdamISZ

Yes, CI is not having errors with current JM master on macos-latest, so closing this for now.

kristapsk avatar Dec 29 '22 05:12 kristapsk

What we might want to do as alternative, if there is no other solution, is to pin to a different version on macOS on aarch64.

kristapsk avatar Dec 29 '22 05:12 kristapsk