colonyNetwork icon indicating copy to clipboard operation
colonyNetwork copied to clipboard

changed usage of code as identifier.

Open nishant-sachdeva opened this issue 2 years ago • 3 comments

We're currently implementing immutable for dynamic types in the compiler. With things like arrays and structs, however, it's much more tedious to enforce the immutability at contract construction time (and not everyone even thinks that this immutability is desirable) so we decided to make them freely writable at that stage instead. To make this clear we're introducing a new keyword: code. This is a breaking change so it will only really become a keyword in 0.9.0.

Turns out that colonyNetwork has one instance of code being used as an identifier. This PR changes its name for future compatibility and also will help us test the compiler against colonyNetwork without having to maintain a fork just for this small tweak.

nishant-sachdeva avatar Oct 26 '22 08:10 nishant-sachdeva

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Oct 26 '22 08:10 CLAassistant

@nishant-sachdeva thanks for letting us know! Can you sign the CLA so we can move forward with the review?

kronosapiens avatar Nov 01 '22 18:11 kronosapiens

Making a note to check with front-end about whether they reference the code variable by name.

kronosapiens avatar Feb 13 '23 16:02 kronosapiens