colonyNetwork
colonyNetwork copied to clipboard
Add function to recover staked funds in misaligned motions
Based on #1081, so no merging. Broadly speaking:
- Have this function declared in a separate file, with the (wrong) storage layout from v4 so that we can use normal-looking solidity to access the misaligned funds.
- Had to introduce IVotingReputation as we're spreading the functions across multiple files
- Slight alteration to implementation in the recovery functions, but hopefully not results. Basically, a motion must be finalized in order for people to be rewarded/punished based on which side they staked on, but because these motions no longer can advance state, I needed to switch to keying off of
finalized
boolean.
This was included in #1084, but if you want more changes will need rebasing and more work from me before being merged in to develop.