colonyDapp icon indicating copy to clipboard operation
colonyDapp copied to clipboard

Annotations not working on Motions

Open arrenv opened this issue 2 years ago • 2 comments

Steps to reproduce

  1. Create a Motion with an annotation.
  2. The annotation won't be visible/or is not recorded at all.

Expected behaviour

  • Annotating on a Motion should display the annotation

Actual behaviour

  • Annotations are not working on Motions

E.g. in production, both with annotations added:

  • Forced: https://xdai.colony.io/colony/ameva/tx/0xe4c9a10480fc1951859b9b51a9872d0f535593e5833b22c59cb1751da8eb369d
  • Motion: https://xdai.colony.io/colony/ameva/tx/0x9a830c90f45e3cc5cd5fbfd570681e54e3bd014bc662254228a1633763cfcdb3

arrenv avatar Nov 16 '22 09:11 arrenv

@arrenv I think we may have inadvertently fixed this in feature/gnosis-safe-control as they are showing over there but not on master.

If you guys want this to be fixed ASAP (Before we merge Safe Control), then I can take a look and compare with what we have in the feature branch and upload a separate branch with the fix for master

ArmandoGraterol avatar Nov 16 '22 20:11 ArmandoGraterol

@arrenv I think we may have inadvertently fixed this in feature/gnosis-safe-control as they are showing over there but not on master.

If you guys want this to be fixed ASAP (Before we merge Safe Control), then I can take a look and compare with what we have in the feature branch and upload a separate branch with the fix for master

Nice, thank you @ArmandoGraterol. Just as long as it is in the next deployment, which will likely be with Safe Control. I don't believe we will have a deployment before then.

arrenv avatar Nov 18 '22 11:11 arrenv