colonyDapp icon indicating copy to clipboard operation
colonyDapp copied to clipboard

Validate total transactions amount against safe balance

Open jakubcolony opened this issue 3 years ago • 2 comments

I noticed there's no validation of the total amount from multiple transactions which can lead to cases like this: image The safe balance is 0.00499 ETH and we're attempting to transfer double the amount.

I originally posted this in #3982 and @willm30 suggested this might constitute scope creep so it'd be great if @ArmandoGraterol you could weigh in on that. For now, I'm adding the On Hold tag to this issue.

jakubcolony avatar Oct 19 '22 10:10 jakubcolony

Just to clarify my thoughts on potential scope creep, it's difficult to estimate if this will be a quick fix or something more involved, and also I'm not clear on how much of a problem it will present to users. So while I think it's a good idea, I wanted to discuss in case it's not worth it. Or potentially one to come back to at the end?

willm30 avatar Oct 19 '22 10:10 willm30

I think your point is sensible, it does seem like it has a fairly limited impact on the overall UX. I don't mind if this is left until the end and only addressed if there's time to do that

jakubcolony avatar Oct 19 '22 10:10 jakubcolony