colonyDapp icon indicating copy to clipboard operation
colonyDapp copied to clipboard

Server status indicator

Open dit7ya opened this issue 2 years ago • 9 comments

Description

This PR adds a server status (healthy | poor | critical) indicator to the user navigation bar.

Notes to reviewers

After halfway through this PR I realized this is a complicated one - and merits to be split into a couple of separate ones. It is NOT DONE yet but it would be very helpful if you point out if I am doing something horribly wrong.

Also, It is not clear to me yet how to best test this without manually editing stuff. But I will think about that and write here. Meanwhile, for checking out the UI component you can manually edit the initial state of the network to be poor and critical here

https://github.com/joincolony/colonyDapp/blob/db5ce6ab889116e857547b3c877c2f40cb6373f9/src/modules/pages/components/RouteLayouts/UserNavigation.tsx#L149-L151

Many thanks to Raul and Arren for helpful pointers.

NOTE: The IPFS and Reputation Oracle being behind checks will be added in a separate PR. New stuff

  • Server status bar

Resolves #3230.

dit7ya avatar Mar 23 '22 16:03 dit7ya

Is this still a work in progress? As the last commit name suggests it's still WIP ?

rdig avatar Mar 28 '22 12:03 rdig

@rdig There are still some things that need to be done on this. But this is ready for review as of now so that I can have some comments/ feedback before moving on with the rest of it. I will change the commit messages with a refactor and rebase.

dit7ya avatar Mar 28 '22 13:03 dit7ya

Great, I'll review it then

rdig avatar Mar 28 '22 13:03 rdig

@dit7ya Please don't forget to set up that call w/ Product

rdig avatar Apr 20 '22 09:04 rdig

@chinins Thanks for the review, moved the enum out. The rationale for splitting the queries is that we might be interested in the individual loading or error states of the requests in this case.

dit7ya avatar Apr 25 '22 04:04 dit7ya

Does anyone remember the status of this one?

arrenv avatar Jul 07 '22 19:07 arrenv

@arrenv

Does anyone remember the status of this one?

I remember that this feature went out to QA and it was difficult to test because we basically needed to manually sabotage our services in order to see changes in the server statuses.

That's the only I can recall, perhaps someone else remembers more

ArmandoGraterol avatar Jul 08 '22 17:07 ArmandoGraterol

There was still something to fix regarding IPFS if I remember correctly, but I haven't had time to look into it.

rdig avatar Jul 08 '22 17:07 rdig

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: ArmandoGraterol
:x: dit7ya
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jan 25 '24 19:01 CLAassistant