svn-scm icon indicating copy to clipboard operation
svn-scm copied to clipboard

Opening a revision in tree view fails for commits with "propset" on "/"

Open ThelloD opened this issue 5 years ago • 3 comments

  • VSCode Version: 1.26.1
  • OS Version: Debian 4.18.10
  • Extension Version: 1.54.3
  • System Language: EN
  • SVN Version: 1.10.4

Issue

Tree view of revisions fails to open for revision where properties have been changed on "/" with error message "Invalid _path".

Likewise, the extension can't handle property changes with the path "/" properly.

Steps to Reproduce

  1. Open command line on root level of the SVN repository (not in a subdirectory)
  2. command line: svn propset svn:ignore "ignore-me" .
  3. Commit (svn ci)
  4. open VSCode, go to Subversion extension (tree view)
  5. Try to unfold latest revision
  6. Unfolding fails with error message "Invalid _path"

SVN Output

Output is generated when opening the subversion view

[svn-test-co]$ svn log -r HEAD:1 --limit=50 --xml -v file:///path/to/test/svn/repo

Clicking on the unfold triangle does not produce any new output but triggers the error message.

Screenshots

svn-error

ThelloD avatar Jul 11 '19 11:07 ThelloD

Not able to reproduce. @ThelloD this still an issue for you?

JohnstonCode avatar Nov 08 '19 15:11 JohnstonCode

Sorry I didn't reply to your question back in 2019 @JohnstonCode, I must have missed it! (wow, what an old issue that came up again... 😄)

I just tried to reproduce the issue, and the behavior still remains the same:

usr@host:/tmp$ svnadmin create svn-dummy-test-REPO
usr@host:/tmp$ svn co file:///tmp/svn-dummy-test-REPO svn-dummy-test      
Checked out revision 0.
usr@host:/tmp$ cd svn-dummy-test
usr@host:/tmp/svn-dummy-test$ echo "Hello World" > test.txt   
usr@host:/tmp/svn-dummy-test$ svn add test.txt         
A         test.txt
usr@host:/tmp/svn-dummy-test$ svn ci -m "test"                                     
Adding         test.txt
Transmitting file data .done
Committing transaction...
Committed revision 1.
usr@host:/tmp/svn-dummy-test$ svn up          
Updating '.':
At revision 1.
usr@host:/tmp/svn-dummy-test$ svn propset svn:ignore "ignore-me" . 
property 'svn:ignore' set on '.'
usr@host:/tmp/svn-dummy-test$ svn ci -m "changed prop"            
Sending        .
Committing transaction...
Committed revision 2.            
usr@host:/tmp/svn-dummy-test$ svn log                 
------------------------------------------------------------------------
r2 | usr | 2024-03-12 14:07:56 +0100 (Tue, 12 Mar 2024) | 1 line

changed prop
------------------------------------------------------------------------
r1 | usr | 2024-03-12 14:07:28 +0100 (Tue, 12 Mar 2024) | 1 line

test
------------------------------------------------------------------------

usr@host:/tmp/svn-dummy-test$ code .           
usr@host:/tmp/svn-dummy-test$ 

In VS Code, the previous error message "Invalid _path" is displayed again, when trying to unfold the latest revision. (In the example above: r2)

grafik

The SVN extension was installed in VS Code just now, so the latest available version (v2.17.0) is being used: grafik

The bug isn't that severe since it's rather a "cosmetic" issue and e.g. won't affect file integrity etc., but it's definitely still present.

ThelloD avatar Mar 12 '24 13:03 ThelloD

Thank you for the re-production steps

JohnstonCode avatar Mar 13 '24 08:03 JohnstonCode