svn-scm icon indicating copy to clipboard operation
svn-scm copied to clipboard

ignoreRepositories option uses incorrect comparison

Open Zevensoft opened this issue 3 years ago • 0 comments

  • VSCode Version: 1.63.2
  • OS Version: 10.0.19042
  • Extension Version: 2.15.2
  • System Language: English (AU)
  • SVN Version: 1.9.7

Issue

Paths listed in ignoreRepositories will fail to match if the string is different even if the path is the same. This is caused by failing to normalise the path correctly.

Steps to Reproduce

  1. Have a project setup like so: /project /project/external1 /project/external1/external2
  2. Set the ignoredRepositories like so: "/project/external1", "/project/external1/external2"
  3. You will now see external1 remains as the second external resulted in a "/project/external1/" path which wont get ignored.

Solution

normalizePath() needs to account for the final slash at the end of the path.

Zevensoft avatar Jan 26 '22 23:01 Zevensoft