Johnny Walker

icon company Secret Cinema icon location London, UK icon location Director of Digital Technology

Results 29 comments of Johnny Walker

fixed more readable

> I think It it better approach This is a good explanation as why it's not a good idea in 99.9% of Laravel projects https://www.youtube.com/watch?v=giJcdfW2wC8

Change test case methods to snake_case and mention Pest support

@alexeymezenin You seem to be engaging with this repo again... How about bringing it up to speed with current Laravel standards?

Is this repository still actively maintained?

The oldest PR is nearly a year old :-/

[Comments] OMG YES

I've just never heard the advice "classes should be small" before. It makes no sense to me taken literally, so perhaps I'm misunderstanding it. Classes should have a single responsibility,...

[Comments] OMG YES

@pixelbrackets Yes indeed. That illustrates the point very well and I agree with the answers that say "small classes" is a useful and helpful intention... expressed poorly. I cracked open...

[Comments] OMG YES

Ok, I've just learned more about John Ousterhout's work. I think I understand why I was having so much difficulty [Too many small methods, classes or modules](https://github.com/zakirullin/cognitive-load#too-many-small-methods-classes-or-modules). However, I also...

Argument #2 ($value) must be of type string, null given

I'm seeing this issue today and my domains are verified.

Direction support for border: border-left, border-right, border-top, border-bottom

I can't believe this library doesn't have this :( It forces you to use inline styles for basic CSS which completely defeats the purpose of having a utility class style...

PendingRequest HTTP methods return Response|PromiseInterface causing false positive method.notFound errors

Not sure that PHPStan can know what the response is if the facade returns `Response|PromiseInterface`. A better workaround might be to check that the $response is not an instance of...