bobby icon indicating copy to clipboard operation
bobby copied to clipboard

Upgrade progress total and done values are inconsistent and confusing

Open MotWnb opened this issue 5 months ago • 0 comments

Describe the bug

When running the /bobby upgrade command, the upgrade progress messages show inconsistent and confusing numbers for "done" and "total" chunks. For example, the first message may be: Bobby] Upgraded 0 of (estimated) 95232 chunks (world 1 of 1). but later messages suddenly change to: [Bobby] Upgraded 18315 of (estimated) 63650 chunks (world 1 of 1). [Bobby] Upgraded 36831 of (estimated) 36831 chunks (world 1 of 1). It appears that the "total" value decreases as the upgrade progresses, and the "done" value may jump forward. This makes it difficult to understand the actual progress, and can be confusing to users.

The ProgressReported class uses Math.max and Math.min to merge done and total values, but the progress callback may provide inconsistent total values.

https://github.com/Johni0702/bobby/blob/12c8f510085ae70ac279f1e4943692f6ce4e1bbb/src/main/java/de/johni0702/minecraft/bobby/commands/UpgradeCommand.java#L93

MotWnb avatar Jul 19 '25 05:07 MotWnb