nova-trumbowyg
nova-trumbowyg copied to clipboard
Johnathan
WIP: Allow Trumbowyg Plugins to be used
Trying to address #3 and #4
At the minute we're still trying to find a way to load the relevant plugin files through the Nova field configuration.
Also interested in this, I will have to check it out what you guys have done. Would love the flexible version @Johnathan is talking about, but I may have to use @timvandijck method if we can't all work together to get the flexible version soon! On a bit of a deadline
I haven’t had a chance to get any further with it, I’ve started a new Nova project so might have a need for it soon but feel free to pitch in if you can.
I would love to use the clean copy plugin. Is there anything specific I can do to get this PR through?
@hyperized apart from time constraints the biggest blocker is I can't find a way to dynamically include the plugins from nova.
If that's something you could look at that would be great.
@Johnathan I know this is an oldy. But by dynamically loading them, do you mean if you pass in something like:
NovaTrumbowyg::make('Description')
->plugins(['one', 'two', 'three'])
If so, that may be weird way of loading it. But considering the average plugin is like, 5kb minified... why bother? If someone is using this on a public instance where this matters, then maybe they can write their own plugin usage.
I'll look in to dynamically loading them. But it may be easier to just load them so everyone can move on to the next task :)
Dynamically loading by passing in a default plunging name or a path to a custom plugin.
I guess for now we could do that if someone can make a PR. But I’d still like to keep this issue open to explore custom plugins.
Oh so you mean like, ->loadPlugin('/plug-ins/my-plugin.js')
Hmm
I’ll see what I can do. I think everything is already instantiated by the time it would get to that part.
This would be very cool, I need a table plugin and am looking in how to enable it :D
PR’s are more than welcome
On Thu, 12 Aug 2021 at 02:52 Vasilj Milošević @.***> wrote:
This would be very cool, I need a table plugin and am looking in how to enable it :D
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Johnathan/nova-trumbowyg/pull/7#issuecomment-897285098, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABDGJOTDZUXUTSX5TFVLGDT4MSOLANCNFSM4FXYKGWQ .