peertube-plugin-livechat icon indicating copy to clipboard operation
peertube-plugin-livechat copied to clipboard

Published 20 hours ago • verified publisher icon JohnXLivingston

Deleted message are shown when loading history

Open JohnXLivingston opened this issue 3 years ago • 1 comments

Describe the bug

When using the builtin Prosody mode, deleted messages are not deleted in chat history.

To Reproduce Steps to reproduce the behavior:

  1. Builtin Prosody mode
  2. Delete a message
  3. Open a private browser window and open the chat
  4. The message is still here

Expected behavior

It seems that messages are not marked as deleted in the room history. So when loading the chat content from the history, deleted messages are shown... It should not.

Note to myself: I think I remember seeing some error logs a long time ago. Something like «cannot mark message as deleted in history when storing history in files».

Server (please complete the following information):

  • peertube-plugin-livechat version: 4.0.2

JohnXLivingston avatar Nov 05 '21 19:11 JohnXLivingston

See comments here: https://github.com/JohnXLivingston/peertube-plugin-livechat/blob/1ea9feaab4088071a9fe2df724e57f4387b3d4fc/server/lib/prosody/config/content.ts#L232-L235

JohnXLivingston avatar Dec 01 '21 13:12 JohnXLivingston

Available in Prosody 0.12. I should try to use debian bullseye-backports to generated the Prosody AppImage (livechat v6).

JohnXLivingston avatar Nov 18 '22 11:11 JohnXLivingston

Fixed by https://github.com/JohnXLivingston/peertube-plugin-livechat/commit/b5901739a94d05f93c679a25c788b7f7157a6bd2

JohnXLivingston avatar Nov 18 '22 16:11 JohnXLivingston