John Villalovos
John Villalovos
> Hmm, that's interesting. I don't see that error on my end. What mypy are you using? I have 0.812 with default settings. I used: ``` $ tox -e mypy...
> It looks like mypy just doesn't like the redundant type hints on the intermediate abstract classes. If you move these to the base class these errors go away. See...
Good idea. Let me explore having it in the base GitlabExeception class. But probably not today...
I notice this on the `user` endpoint I removed the non `RateLimit` headers. ``` {'RateLimit-Limit': '2000', 'RateLimit-Observed': '20', 'RateLimit-Remaining': '1980', 'RateLimit-Reset': '1645057248', 'RateLimit-ResetTime': 'Thu, 17 Feb 2022 00:20:48 GMT'} ```
Looks like we need to add support for these new headers: https://docs.gitlab.com/ee/user/admin_area/settings/user_and_ip_rate_limits.html#response-headers
> @JohnVillalovos I don't believe that change will solve my original issue. There are no rate-limit or retry headers at all when the rate limit is hit on `/users/:id`: >...
Unfortunately this is easier said than done 😢 At least in my attempts I didn't have much success doing it. But I only spent maybe an hour or two trying...
Thinking about this some more I think the easiest fix would be to get rid of the `streamed` and `raw` arguments from `http_get` and have the callers that need it...
> I think we need to fix tox yes, just noticed recently. I think you'll need to run environments individually as one of the builds leaves artifacts that trip up...
Note https://github.com/python-gitlab/python-gitlab/commit/834677e24a687e80374d1cf00f514c80248c6221 is only a rebase with no functional changes. Had conflicts after another PR merged. Will work on fixing things in regards to comments later on today most likely.