ShellOut icon indicating copy to clipboard operation
ShellOut copied to clipboard

Change shell from bash to zsh

Open tapi opened this issue 4 years ago • 2 comments

Since MacOS now ships with zsh I think it would make sense to change the shell used by ShellOut to match. I was just bitten by an issue where file globbing behaviours were different between the two and debugging it made no sense since it worked when run manually.

Alternatively the shell could be made configurable. Happy to make the change, just wanted to start the discussion first.

tapi avatar Jun 01 '20 14:06 tapi

I hit this recently too. Agree it would be good to be able to assign or override the launchPath and similar used by the underlying process to better support zsh.

However, in the mean time I have just added an abstracted Process class named ZSHProcess which will ensure it uses the things I need.

ghost avatar Nov 21 '20 05:11 ghost

Didn't know there was an open issue for this. I submitted a PR for a quick way to add this option last month. Don't know if it will ever get merged but feel free to fork off my version if it's of any use!

leoidiaz avatar Dec 23 '21 01:12 leoidiaz