John Starich
John Starich
>The main issue I've found with this approach is `fstest`. Because it's doing direct type assertions instead of using the `hackpadfs.*` helper functions, it doesn't handle "unwrapping" `MountFS`. That's a...
I spent the weekend updating `hackpadfs` to Go 1.19, which took longer than expected. Will return to this one soon.
It took some time to rehash everything, but I think it's nailed now. @duckbrain How's the latest release `v0.1.12` looking for you?
Ack, I realized just now your PR actually did many similar changes. In particular the same bug fixes encountered when improving `fstest` 🤦 I'll be more careful next time, you...
Hey @duckbrain, is the latest release working well for you? I'll go ahead and close, but we can reopen if you hit issues.
Thanks for your contribution @duckbrain! This was largely similar to #28 (which I mistakenly did after this was opened), so I'll go ahead and close.
> ... enabling it by default until v2 ... @ernado Is it too late for v2 to change the default? My issue with the above solution is it's cumbersome to...
Perhaps a new field can be added to v1 to re-enable default excludes? ```yaml issues: include: - (comment on exported (method|function|type|const)|should have( a package)? comment|comment should be of the form)...
> You are right, but we can't enable this now because this will lead to new unexpected linting issues on minor version update, which is kinda breaking and annoying. Totally...
I'd be happy to work up a PR once we settle on a design