draw icon indicating copy to clipboard operation
draw copied to clipboard

Show selected objects to other users

Open tranek opened this issue 12 years ago • 9 comments

If person A selects a path, everyone else should be able to see that he has that path selected.

I'm waiting on this to hear back from the paperjs folks about setting custom selection colors instead of the default blue. That way we can show the selection in the color of the user who selected it (assuming we have artist colors as suggested in #60.

tranek avatar May 07 '13 07:05 tranek

What happens if two users move the same path? Who wins that race condition?

JohnMcLear avatar Jun 27 '13 20:06 JohnMcLear

Well the server's copy of the paper object will move the item however many units in whatever direction by the first message that's received and then by the second. I think it will actually even out at the end and everyone will be synced with a combination of the moves.

tranek avatar Jun 28 '13 00:06 tranek

what if two users move it 10px to the right? Surely it will move a total of 20px to the right confusing everyone?

JohnMcLear avatar Jun 28 '13 01:06 JohnMcLear

I would expect that behavior to happen, yes. That was the motivation behind the object ownership/operation transform discussion. In the meantime, once we add author colors (separate from current stroke/fill color), we can emit that an object is selected by that author's color. It won't stop the case where two people click the same thing at the same time, but it would "help".

tranek avatar Jun 28 '13 02:06 tranek

Oh speaking of author colors, how do you envision that fitting into the new UI? Also, the new UI doesn't display the user's currently selected stroke/fill color. Is that by design?

tranek avatar Jun 28 '13 02:06 tranek

good point, ideally the cursor would reflect the chosen design. It isn't by design, it's not a bug, its just something I didn't feel we needed at the time but you are right that it will make for a better UX

JohnMcLear avatar Jun 28 '13 12:06 JohnMcLear

@tranek for now I use the border botom color to identify the users current color, I quite like it but it's probably a stop gap.. Changing the background on the user icon is probably an idea too.. Feel free to tweak :)

JohnMcLear avatar Jun 28 '13 13:06 JohnMcLear

That's a neat way to do it. Not immediately apparent since the default color is black but I think it's okay for now.

Do you agree that we should have a separate color for the author like Etherpad has? This separate color would be used for the chat (if ever implemented) and for selection purposes.

tranek avatar Jun 28 '13 13:06 tranek

I dunno about that yet, because color is such an important part of our process

I think it might be better if we assign a default color then just on hover show the author name.

So yeah TLDR;

Assign initial unique author color (used for chat etc) Prompt user for username if not set Hover show username for item

JohnMcLear avatar Jun 28 '13 13:06 JohnMcLear